Fix pywwt on notebook >=5.7.6
#192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI is failing here in the same way as #149. Importantly, the failure mode is actually not the same as what I showed in my first related comment on that issue. Here, and for the latest CI runs on #149, the "actual" image is all black. I can't reproduce on my Linux machine locally, so I'm not sure what's gone wrong ... any thoughts @astrofrog? |
This was referenced Mar 31, 2019
ojustino
added a commit
to ojustino/pywwt-web
that referenced
this pull request
Apr 3, 2019
Version 5.7.6 of the Jupyter notebook module adds a new security feature related to the HTTP content types (jupyter/notebook#4467 (comment)). It breaks pywwt because pywwt has not been returning valid MIME types (AKA content types) from its internal Jupyter server. From looking at the main `notebook` implementation, it seems that the correct approach is to use the `mimetypes` module to get the right value to put in the Content-Type header, so let's go ahead and do that. Closes WorldWideTelescope#191.
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
- Coverage 58.67% 58.66% -0.02%
==========================================
Files 24 24
Lines 1631 1633 +2
==========================================
+ Hits 957 958 +1
- Misses 674 675 +1
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 5.7.6 of the Jupyter notebook module adds a new security feature related to the HTTP content types (jupyter/notebook#4467 (comment)). It breaks pywwt because pywwt has not been returning valid MIME types (AKA content types) from its internal Jupyter server.
From looking at the main
notebookimplementation, it seems that the correct approach is to use themimetypesmodule to get the right value to put in the Content-Type header, so let's go ahead and do that.Closes #191.