Add FITS MIME type #208
Merged
Add FITS MIME type #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkgw
approved these changes
May 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 58.12% 58.02% -0.11%
==========================================
Files 24 24
Lines 1667 1670 +3
==========================================
Hits 969 969
- Misses 698 701 +3
Continue to review full report at Codecov.
|
|
I rebased this on the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python mimetype library does not include the MIME type information for FITS files by default, so we have to add it. Otherwise adding FITS images breaks pywwt on notebooks 5.7.6 and up. (See #191 and #192 for more info on notebooks and MIME types)