-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple entrypoint & multi_tan detection #68
Conversation
…l projection from a list of FITS files
Hmm... That segmentation fault is interesting. Anything you've seen before, @pkgw? |
Maybe the failing test did not run on Azure before, since it is marked with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! I have some suggestions below.
I pushed a commit to your branch to see if it helped to upgrade to Python 3.9 for the coverage test, but it looks like it didn't.
For the shapely issue: I think that your change to That being said ... it's certainly not clear to my why your changes would cause the |
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 74.69% 75.37% +0.67%
==========================================
Files 22 22
Lines 3051 3098 +47
==========================================
+ Hits 2279 2335 +56
+ Misses 772 763 -9
Continue to review full report at Codecov.
|
Alright! All review comments fixed and all CI issues addressed (sort of). There were three issues discovered in CI, of which two are fully solved and one which is still being investigated.
|
Well, "good" news that I can reproduce the parallel deadlock locally, so it should be quick to fix. |
Ah, yes: the merge task would get stuck when |
5e5e573
to
0d59d6a
Compare
Ah, now I see where the shapely issue is coming from. I've force-pushed a new history that ought to fix it (might take a couple of tries) and also tidies up the history regarding the CI issues. |
As per the comment added to `azure-build-and-test.yml`: normally we try to pull in as many deps as possible using `pip` to test out our internal metadata, but this doesn't work well for the coverage run. Rearrange it to use conda to pull in all of the dependencies.
0d59d6a
to
1814895
Compare
This PR is used in WorldWideTelescope/pywwt#316