Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grade scaling bug with bluetooth #362

Closed
decodeais opened this issue Jan 13, 2022 · 4 comments
Closed

Grade scaling bug with bluetooth #362

decodeais opened this issue Jan 13, 2022 · 4 comments
Labels
bug Something isn't working solved

Comments

@decodeais
Copy link

decodeais commented Jan 13, 2022 •
edited
Loading

Hello, this little bug droves us crazy. For my wife the Grade parameter worked but not for me. She rides with the old Rouvy App and I with the new one. We found out that the reason was that the old Rouvy app uses only ANT+ and the new one only Bluetooth.
The source code showed the reason. The calculation was OK but not used.

Here in line 1357is the original grade sent to the trainer
TacxTrainer.SetGrade(bleCTP.TargetGrade)

with this change it worked
TacxTrainer.SetGrade(Grade)

please put this little change to the source.
WouterJD added a commit that referenced this issue Jan 13, 2022
@WouterJD
#362 Grade was not adjusted by -G for BLE
640f95b
@WouterJD
Copy link
Owner

You are right, I have updated FortiusAntBody.py; please verify

@WouterJD WouterJD added bug Something isn't working solved under investigation Being studied for implementation in next version labels Jan 13, 2022
@decodeais
Copy link
Author

I tested it one hour with Rouvy and worked perfectly. I don' t understand how it could be undetected so long. It is absolute important for this App.
Thank you for your quick respond.

@WouterJD WouterJD removed the under investigation Being studied for implementation in next version label Jan 13, 2022
@WouterJD
Copy link
Owner

Hi @decodeais evidently you were the first using this combi :-)
Thanks for the work and I'll close the issue

@WouterJD
Copy link
Owner

Implemented in https://github.com/WouterJD/FortiusANT/tree/Implement-BLE-using-bless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working solved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@decodeais @WouterJD