Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #21 - Init msg only with new protocol #22

Conversation

fritz-hh
Copy link
Contributor

Fixes #21

Only send an initialization message to the trainer device, if it talks using the new protocol.

Fixes WouterJD#21

Only send an initialization message to the trainer device, if it talks using the new protocol.
@fritz-hh
Copy link
Contributor Author

Note: I have moved sending the initialization message to GetTrainer, as to me, uploading the firmware and sending the init message are both part of the initialization.

@fritz-hh
Copy link
Contributor Author

I tried to make very small pull requests, so that they are easier for you to review and merge

Copy link
Owner

@WouterJD WouterJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the version info at the top of the file.

@WouterJD WouterJD merged commit bd6832e into WouterJD:master Mar 2, 2020
@fritz-hh fritz-hh deleted the issue-#21---Sent-init-msg-only-for-new-protocol branch March 7, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InitializeTrainer only applies to Fortius, not to Imagic
2 participants