fix tslint config, but it wont print errors for some reason

WuTheFWasThat · Aug 2, 2018 · f5baada · f5baada
1 parent 3309398
commit f5baada
Show file tree

Hide file tree

Showing 4 changed files with 118 additions and 49 deletions.
diff --git a/index.d.ts b/index.d.ts
@@ -1,6 +0,0 @@
-// @types/react-color exists but doesn't work
-declare module 'react-color' {
-  export const PhotoshopPicker: any;
-  export const SketchPicker: any;
-  export const ChromePicker: any;
-}

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -18,6 +18,7 @@
     "verify": "npm run lint && npm run typecheck && npm test"
   },
   "dependencies": {
+    "@types/react-color": "^2.13.5",
     "express": "^4.16.3",
     "lodash": "^4.17.10",
     "minimist": "^1.2.0",
@@ -37,7 +38,7 @@
     "@types/webpack": "^4.4.8",
     "@types/webpack-dev-server": "^2.4.0",
     "@types/ws": "0.0.41",
-    "awesome-typescript-loader": "^3.1.3",
+    "awesome-typescript-loader": "^5.2.0",
     "core-js": "^2.4.1",
     "css-loader": "^0.23.1",
     "file-loader": "^0.9.0",
@@ -57,7 +58,7 @@
     "style-loader": "^0.13.1",
     "ts-node": "^3.1.0",
     "tslint": "^4.5.1",
-    "tslint-loader": "^3.5.3",
+    "tslint-loader": "^3.6.0",
     "typescript": "^3.0.1",
     "webpack": "^4.16.3",
     "webpack-dev-server": "^3.1.5"

diff --git a/src/server/webpack_configs.ts b/src/server/webpack_configs.ts
@@ -27,8 +27,18 @@ export function getDevConfig(config: BuildConfig = {}): webpack.Configuration {
       rules: [
         {
           test: /\.tsx?$/,
+          enforce: 'pre',
           use: [
-            'react-hot-loader', 'awesome-typescript-loader', 'tslint-loader',
+            {
+              loader: 'tslint-loader',
+              options: { emitErrors: false, failOnHint: false, }
+            },
+          ],
+        },
+        {
+          test: /\.tsx?$/,
+          use: [
+            'react-hot-loader', 'awesome-typescript-loader',
           ],
           include: srcdir
         },
@@ -58,10 +68,6 @@ export function getDevConfig(config: BuildConfig = {}): webpack.Configuration {
       new CheckerPlugin(),
       new webpack.LoaderOptionsPlugin({
         options: {
-          tslint: {
-            emitErrors: true,
-            failOnHint: true
-          },
           css: {
             sourceMap: true,
             root: '/build',
@@ -73,6 +79,7 @@ export function getDevConfig(config: BuildConfig = {}): webpack.Configuration {
     resolve: {
       extensions: ['.jsx', '.js', '.tsx', '.ts']
     },
+    stats: 'verbose'
   };
 }
 
@@ -84,10 +91,20 @@ export function getProdConfig(config: BuildConfig = {}): webpack.Configuration {
     entry: `${srcdir}/assets/ts/app.tsx`,
     module: {
       rules: [
+        {
+          test: /\.tsx?$/,
+          enforce: 'pre',
+          use: [
+            {
+              loader: 'tslint-loader',
+              options: { emitErrors: true, failOnHint: true, }
+            },
+          ],
+        },
         {
           test: /\.tsx?$/,
           use: [
-            'awesome-typescript-loader', 'tslint-loader',
+            'awesome-typescript-loader',
           ],
           include: srcdir
         },
@@ -119,10 +136,6 @@ export function getProdConfig(config: BuildConfig = {}): webpack.Configuration {
       new CheckerPlugin(),
       new webpack.LoaderOptionsPlugin({
         options: {
-          tslint: {
-            emitErrors: true,
-            failOnHint: true
-          },
           css: {
             sourceMap: true,
             root: '/build',
@@ -153,10 +166,20 @@ export function getProdServerConfig(config: BuildConfig = {}): webpack.Configura
     externals: nodeModules,
     module: {
       rules: [
+        {
+          test: /\.tsx?$/,
+          enforce: 'pre',
+          use: [
+            {
+              loader: 'tslint-loader',
+              options: { emitErrors: true, failOnHint: true, }
+            },
+          ],
+        },
         {
           test: /\.ts$/,
           use: [
-            'awesome-typescript-loader', 'tslint-loader',
+            'awesome-typescript-loader'
           ],
           include: srcdir
         },
@@ -172,14 +195,6 @@ export function getProdServerConfig(config: BuildConfig = {}): webpack.Configura
     },
     plugins: [
       new CheckerPlugin(),
-      new webpack.LoaderOptionsPlugin({
-        options: {
-          tslint: {
-            emitErrors: true,
-            failOnHint: true
-          },
-        }
-      }),
     ],
     resolve: {
       extensions: ['.js', '.ts']