Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do about StructType::Form #70

Closed
hasezoey opened this issue Aug 31, 2023 · 1 comment · Fixed by #72 or #121
Closed

What to do about StructType::Form #70

hasezoey opened this issue Aug 31, 2023 · 1 comment · Fixed by #72 or #121

Comments

@hasezoey
Copy link
Collaborator

Currently there is a variant called Form in StructType, but it is unused and cannot be used outside of the library, so i would like to know if we can remove this, or the wanted behavior this should have so it can be implemented

Form, // this one contains primary key columns (not optional) and normal columns (optional) excluding those marked as autogenerated

@Wulf
Copy link
Owner

Wulf commented Sep 3, 2023

Yes please remove this and good catch @hasezoey. The struct generation code saw multiple iterations. This is a remnant of an older iteration.

hasezoey added a commit to hasezoey/dsync that referenced this issue Sep 4, 2023
hasezoey added a commit to hasezoey/dsync that referenced this issue Sep 4, 2023
hasezoey added a commit that referenced this issue Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants