Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality (some refactors) #74

Merged
merged 9 commits into from
Sep 5, 2023
Merged

Code quality (some refactors) #74

merged 9 commits into from
Sep 5, 2023

Conversation

hasezoey
Copy link
Collaborator

@hasezoey hasezoey commented Sep 4, 2023

This PR does mainly refactors, removing unnecessary .clone() or taking in arguments that are not necessary and a reference is enough, in more details:

  • replace some inputs which take in ParsedTableMacro to take in &ParsedTableMacro
  • replace some inputs which take in PathBuf with &Path
  • inline some direct variable renames
  • remove clones which are not necessary
  • remove some things that can be omitted (like &'_ str can just be &str, and String.as_str() with &String)

@hasezoey hasezoey force-pushed the codeQuality branch 2 times, most recently from dd24e77 to 4f1d78d Compare September 4, 2023 18:12
@Wulf Wulf force-pushed the main branch 2 times, most recently from f29f86a to 58f0832 Compare September 4, 2023 21:25
@hasezoey hasezoey merged commit a0e77a8 into Wulf:main Sep 5, 2023
6 checks passed
@hasezoey hasezoey deleted the codeQuality branch September 5, 2023 09:57
@hasezoey hasezoey mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wulf Wulf Wulf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hasezoey @Wulf