Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality (some refactors) #74

Merged
merged 9 commits into from
Sep 5, 2023
Merged

Code quality (some refactors) #74

merged 9 commits into from
Sep 5, 2023

Commits on Sep 5, 2023

  1. refactor(parser): remove some unnecessary clones

    @hasezoey
    hasezoey committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    0a952fb View commit details
    Browse the repository at this point in the history

  2. refactor(code): change "generate_for_table" to take in a table reference 

    because it is only used as a reference anyway
    @hasezoey
    hasezoey committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    4d7dfc0 View commit details
    Browse the repository at this point in the history

  3. refactor(parser): change "parse_and_generate_code" to take in a "&str… 

    …" instead of "String"
    @hasezoey
    hasezoey committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    f81caa8 View commit details
    Browse the repository at this point in the history

  4. style(code): remove some unnecessary extra calls

    @hasezoey
    hasezoey committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    e504c07 View commit details
    Browse the repository at this point in the history

  5. refactor(file): remove clone from "new"

    @hasezoey
    hasezoey committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    359adc7 View commit details
    Browse the repository at this point in the history

  6. refactor(lib): remove clone from "autogenerated_columns"

    @hasezoey
    hasezoey committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    0bac455 View commit details
    Browse the repository at this point in the history

  7. fix(lib): change "generate_files" to take in "&Path" instead of "Path… 

    …Buf"
    @hasezoey
    hasezoey committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    a9c0378 View commit details
    Browse the repository at this point in the history

  8. style(lib): inline variable renames in "generate_files"

    @hasezoey
    hasezoey committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    8863d10 View commit details
    Browse the repository at this point in the history

  9. style(lib): remove some unnecessary extra calls

    @hasezoey
    hasezoey committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    9d9ad20 View commit details
    Browse the repository at this point in the history