Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Romanian translation #626

Merged
merged 21 commits into from
Apr 20, 2022
Merged

Conversation

Drajbonel
Copy link
Contributor

Romanian translations for wurst hack

Description

What have you added and what does it do? (Alternatively, what have you fixed and how does it work?)

(Optional) screenshots / videos

If applicable, add screenshots or videos to help explain your pull request.

Romanian translations for wurst hack
@Alexander01998 Alexander01998 changed the title ro Romanian translation Apr 18, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 18, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@Alexander01998 Alexander01998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found some issues and fixed most of the smaller ones already. However, there is also quite a bit of untranslated English text mixed in, which I have marked with comments. Please translate that too.

src/main/resources/assets/wurst/lang/ro Outdated Show resolved Hide resolved
src/main/resources/assets/wurst/lang/ro Outdated Show resolved Hide resolved
src/main/resources/assets/wurst/lang/ro Outdated Show resolved Hide resolved
src/main/resources/assets/wurst/lang/ro Outdated Show resolved Hide resolved
src/main/resources/assets/wurst/lang/ro Outdated Show resolved Hide resolved
src/main/resources/assets/wurst/lang/ro Outdated Show resolved Hide resolved
src/main/resources/assets/wurst/lang/ro Outdated Show resolved Hide resolved
src/main/resources/assets/wurst/lang/ro Outdated Show resolved Hide resolved
src/main/resources/assets/wurst/lang/ro Outdated Show resolved Hide resolved
@Alexander01998 Alexander01998 self-assigned this Apr 18, 2022
@Alexander01998
Copy link
Member

@Drajbonel I honestly think you might have dyslexia. The amount of tiny mistakes that were in this translation is so much higher than what I usually find.

Copy link
Member

@Alexander01998 Alexander01998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now thoroughly reviewed this line by line and fixed what I could. There are a couple more issues that I need your help with.

src/main/resources/assets/wurst/lang/ro Outdated Show resolved Hide resolved
src/main/resources/assets/wurst/lang/ro Outdated Show resolved Hide resolved
src/main/resources/assets/wurst/lang/ro Show resolved Hide resolved
src/main/resources/assets/wurst/lang/ro Outdated Show resolved Hide resolved
src/main/resources/assets/wurst/lang/ro Show resolved Hide resolved
Alexander01998 added a commit that referenced this pull request Apr 20, 2022
@Alexander01998 Alexander01998 merged commit cc03c61 into Wurst-Imperium:master Apr 20, 2022
@Alexander01998 Alexander01998 added the status:merged This pull request has been merged, even if GitHub says otherwise. label Apr 20, 2022
@Alexander01998 Alexander01998 added this to the v7.24 milestone Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:merged This pull request has been merged, even if GitHub says otherwise. type:translation
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants