Check requirements #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
JoshKarpel
suggested changes
Jan 5, 2020
setup.py
Outdated
| @@ -18,13 +18,15 @@ | |||
| with open('LICENSE') as f: | |||
| license = f.read() | |||
|
|
|||
| with open('requirements.txt') as f: | |||
| requirements = f.read() | |||
There was a problem hiding this comment.
I suspect this has to be f.read().splitlines(), but I'm not sure.
There was a problem hiding this comment.
you are correct, fixed in commit 16cab89
| @@ -0,0 +1,393 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Looks like build/ snuck back into the repo - that directory should not be checked in.
There was a problem hiding this comment.
I think the housekeeping branch under PR #57 has taken care of this. I'll check this again after merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding requirements to the setup and making uposham as an installable module. This should fix #54.
From now on the pip install can be replaced by
python setup.py install(Fixes #9) and the code directory structure is finalized for the installation (Fixes #8).