Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

280: Copy PropertyGroup API broken for uneven collections #513

Closed
tngreene opened this issue Dec 30, 2019 · 1 comment
Closed

280: Copy PropertyGroup API broken for uneven collections #513

tngreene opened this issue Dec 30, 2019 · 1 comment

Comments

@tngreene
Copy link
Contributor

Discovered while filing #510.

While e67cf51 allows new Blender 2.80 projects to use Collections, the updater's property group copy API is broken.

for source_member, dest_member in zip(source_members, dest_members):

if source_members (a collection of say 4 LR directives) and dest_members (0, of course) then nothing is copied. This API was developed for two collections that were always going to be the same length. See #493 also for when we'll fix this.

The fix is simple: while len(source_members) > dest_members.add(). If we have to remove any by that point, something is wrong. dest_members should be empty or perfect from other update utils.

@tngreene
Copy link
Contributor Author

I think this is breaking various.test's custom header properties. I've corrected the test to make up for the updater's fault, but, I think this is an example of not copying a list.

tngreene added a commit that referenced this issue Jan 16, 2020
… copying and also for some reason the test was mixed root objects and layers mode. xplane_updater_helpers.py will one day be filled out, probably soon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant