Create _WinDate structure that stored Date values in a VO struct just like VO does. #773

RobertvanderHulst · 2021-09-06T07:56:19Z

…sents a Date inside a VOSTRUCT or UNION. Fixes #X-Sharp/XSharpPublic/issues/773

… Union + test

leon-ts · 2021-09-06T09:40:27Z

Wow, great!

* [Compiler tests] Added tests for X-Sharp/XSharpPublic#770 and X-Sharp/XSharpPublic#771 * [Compiler] Fixes #X-Sharp/XSharpPublic/issues/771 Create Usuals with IsByRef flag set to TRUE for OUT variables. Also modified the RefKind for the Temporary local because the SynthesizedLocal type does not like RefKind.Out. * [Tests] Added new group and moved C799 to fixed tests * [Compiler] Added support + test for the new __WinDate type that represents a Date inside a VOSTRUCT or UNION. Fixes #X-Sharp/XSharpPublic/issues/773 * Fixes #X-Sharp/XSharpPublic/issues/603 and adds test case R800 * Fixes #X-Sharp/XSharpPublic/issues/772 * Added test for #X-Sharp/XSharpPublic/issues/772 * Updated test R742 for the FoxPro array access with parenthesized indices * [Compiler] Renamed Compiler option fox2 to FoxArraySupport. Fixes #X-Sharp/XSharpPublic/issues/746 and R742 * Updated several keywords * Updated Doc files * [Compiler] More changes for FoxPro Array support. Also added test to runtime tests * [Compiler tests] Added C802 - Internal Compiler Error with multiple PRIVATE &varName commands for X-Sharp/XSharpPublic#780 * [Compiler] Fixes #X-Sharp/XSharpPublic/issues/780 Fixes C802. marks test as fixed. * [Compiler] temporary update FoxPro SQL * [Compiler] Defaults for USUAL are noe default(usual) for non Fox dialects, and __Usual._NIL for the FoxPro dialect * [Compiler] Updated version number. VSParser does not run the Preprocessor when ParserLevel = ParseLevel.Lex * [Compiler] Only FoxPro dialect now uses __Usual._NIL for empty usuals. We now allow __Usual.NIL to be a field (Vulcan) or a property. Also added test R803 to make sure that NIL is never overwritten * [Tests] Added assertions to R803 * [Compiler] Fix problem with missing arguments passed to a function that expects a REF USUAL or OUT USUAL. A Previous solution could lead to the __Usual._NIL value to become corrupted. * [tests] Removed WAIT from 2 tests and marked tests as fixed. * [Compiler] Change error message when they are passing NIL to a method / function that has a REF or OUT parameter * [tests] Updated Runtime to 2.9 Co-authored-by: cpyrgas <chris@xsharp.eu>

cpyrgas · 2021-10-07T08:03:02Z

This has caused some problems unfortunately. This is from Leonid's code, which was compiling and running without errors previously:

prg(9,2): error XS0034: Operator '-' is ambiguous on operands of type 'DATE' and 'XSharp.__WinDate'
prg(10,2): error XS0030: Cannot convert type 'XSharp.__WinDate' to 'dword'

FUNCTION Start() AS VOID STRICT
	LOCAL nDays AS DWORD
	LOCAL dNow AS DATE
	LOCAL ts IS TEST_STRUCT
	
	dNow := Today()
	ts.dDate := Today()
	nDays := dNow - ts.dDate
	nDays := DWORD(_CAST, ts.dDate)

VOSTRUCT TEST_STRUCT
	MEMBER dDate AS DATE

RobertvanderHulst · 2021-10-07T08:42:53Z

I think this are 2 different issues:

I have added numeric operators to __WInDate. (+, - ). Apparently that was not needed and is confusing the compiler.
I will add an explicit conversion from __WinDate to DWORD.

RobertvanderHulst · 2021-10-07T09:56:02Z

I reviewed case #1. This error does not happen because there are numeric operators on the __WinDate type, but because there are several numeric operators on the Date Type. We have these operators:

STATIC OPERATOR -(lhs AS DATE, rhs AS DATE) AS LONG
STATIC OPERATOR -(lhs AS DATE, days AS USUAL) AS USUAL
STATIC OPERATOR -(lhs AS DATE, days AS REAL8) AS DATE
STATIC OPERATOR -(lhs AS DATE, days AS LONG) AS DATE
STATIC OPERATOR -(lhs AS DATE, days AS INT64) AS DATE
STATIC OPERATOR -(lhs AS DATE, ts AS System.TimeSpan) AS DATE
STATIC OPERATOR -(lhs AS DATE, days AS DWORD) AS DATE
STATIC OPERATOR -(lhs AS DATE, days AS UINT64) AS DATE

The compiler does not know which one to choose.
I will change the compiler to detect a binary operation that involves a Date and a __WinDate and then to automatically cast the __WinDate side to Date.

BTW the operation nDays := dNow - ts.dDate returns a LONG (dDate can be larger than dNow). So nDays should be declared as LONG and not as DWORD. If you enable /vo4 this is not needed but if you then change
ts.dDate := Today()
to
ts.dDate := Today()+1
then nDays will have a value of UInt32.MaxValue

…. For issue #773

…r problems with the __WinBool type

leon-ts · 2021-10-07T11:26:45Z

Robert,

BTW the operation nDays := dNow - ts.dDate returns a LONG (dDate can be larger than dNow). So nDays should be declared as LONG and not as DWORD.

I just did this for an example so that for both cases I declare one variable. In a real application, the following code (template):
IF ( (dDate - st.dDate) > nSomeDays )

leon-ts · 2021-10-08T10:41:15Z

Robert,
There are new errors:

LOCAL nDays AS DWORD
LOCAL ts IS TEST_STRUCT
	
nDays := 10
ts.dDate := Today()
ts.dDate += ( nDays - 1 ) // Error XS0034 Operator '+=' IS ambiguous ON operands OF type 'XSharp.__WinDate' and 'dword'
ts.dDate -= ( nDays - 1 ) // Error XS0034 Operator '-=' IS ambiguous ON operands OF type 'XSharp.__WinDate' and 'dword'
ts.dDate += 1 // Error XS0029 Cannot implicitly convert type 'int' TO 'XSharp.__WinDate'
ts.dDate -= 1 // Error XS0029 Cannot implicitly convert type 'int' TO 'XSharp.__WinDate'
ts.dDate++ // Error XS0035 Operator '++' is ambiguous on an operand of type 'XSharp.__WinDate'
ts.dDate-- // Error XS0035 Operator '--' is ambiguous on an operand of type 'XSharp.__WinDate'
	
LOCAL dStart, dEnd AS DATE
dStart := Today()
dEnd := dStart
	
FOR ts.dDate := dStart UPTO dEnd // Error XS0029 Cannot implicitly convert type 'int' TO 'XSharp.__WinDate'
NEXT

VOSTRUCT TEST_STRUCT
	MEMBER dDate AS DATE

RobertvanderHulst · 2021-10-11T07:22:03Z

Leonid,
I will check to see why the compound (+= etc) assignments are failing. If you write this as regular assignments then these will work.
The for loop is a different thing. I'll see what we can do there. But do not expect these 2 changes to become part of the official 2.9 build. I do not want to delay this build for too much longer. People are getting impatient.

cpyrgas · 2021-10-11T08:18:55Z

Robert, maybe it's better to roll back completely the change with introducing _WinDate for now? I am afraid there will be problems in other people's code as well because of that. What would be the consequences of reverting the change (for now)? I think it's only that DATEs in structures will not be binary equal to VO, which is not really a big problem, is that right?

RobertvanderHulst · 2021-10-11T08:21:23Z

Chris,
I do not think there will be consequences for others peoples code. This really only has effect on people that were using a DATE variable in a VOSTRUCT or UNION. So far Leonid / Comintec is the only customer that has reported to use this.

cpyrgas · 2021-10-11T08:35:30Z

I am sure there are more. The code in the asbau project used that as well.

leon-ts · 2021-10-11T08:48:35Z

Guys,

In my projects, I have not found any other problems with the __WinDate type, besides the ones I described above. If suddenly this information will be useful to you for making a decision. For my part, I can only hope that these fixes, if they are not complex, will still get to version 2.9 or at least to the next patch after it. Since I have a lot of similar code.

leon-ts · 2021-10-19T15:51:38Z

Robert,
In my project, I found another serious problem with the DATE type inside a VOSTRUCT. Assignment from a USUAL variable does not work. For example, reading from a DBF file:
somestrcut.dDate: = FieldGetSym(#DATEFIELD)

Here's a simple reproducible example:

LOCAL u AS USUAL
LOCAL ts IS TEST_STRUCT
u := Today()
ts.dDate := u
? ts.dDate // NULL_DATE instead of current date

VOSTRUCT TEST_STRUCT
	MEMBER dDate AS DATE

Also, please note that the debugger is showing the wrong field type (see screenshot):

RobertvanderHulst · 2021-10-19T16:35:33Z

Leonid,
For now add a (DATE) cast in front of the Right Hand Side of the expression.
ts.dDate := (DATE) u
This will be fixed asap.

The LOGIC text in the debugger is a copy/paste error and very easy to fix.

RobertvanderHulst · 2021-10-21T15:43:37Z

Leonid,
Can you confirm that this works, with the exception of the assignment of the usual to the __WinDate element ?

cpyrgas · 2021-10-21T15:56:26Z

Robert, all the issues mentioned here #773 (comment) still exist

cpyrgas · 2021-10-21T16:05:10Z

Arghh, thought the test (C804) had included those, but it doesn't. Updating it now.

leon-ts · 2021-10-21T18:04:03Z

Robert,
I have nothing to add to what Chris said. The errors I mentioned in the section "There are new errors" remained in the new 2.9 compiler.

…warded to the __Date type. Also fixed a problem in __Date:Subtract(USUAL)

…SharpPublic/issues/773

cpyrgas · 2021-10-30T15:02:37Z

Confirm fixed

leon-ts · 2021-11-05T12:23:26Z

Robert,
It works well now!

RobertvanderHulst added enhancement Runtime Compiler labels Sep 6, 2021

RobertvanderHulst added a commit to X-Sharp/XSharpDev that referenced this issue Sep 6, 2021

[Compiler] Added support + test for the new __WinDate type that repre…

90419e1

…sents a Date inside a VOSTRUCT or UNION. Fixes #X-Sharp/XSharpPublic/issues/773

RobertvanderHulst self-assigned this Sep 6, 2021

RobertvanderHulst referenced this issue Sep 6, 2021

[Runtime] Added __WinDate type to store DATE values inside VOSTRUCT &…

1b1dd96

… Union + test

cpyrgas pushed a commit to X-Sharp/XSharpDev that referenced this issue Oct 7, 2021

[Compiler tests] Added C804 for X-Sharp/XSharpPublic#773

2c1b26e

RobertvanderHulst added a commit that referenced this issue Oct 7, 2021

[Runtime] Adds Implicit cast to LONG and DWORD for the __WinDate type…

1301317

…. For issue #773

RobertvanderHulst added a commit to X-Sharp/XSharpDev that referenced this issue Oct 7, 2021

[Compiler] Fixes #X-Sharp/XSharpPublic/issues/773 and possible simila…

1bebbc2

…r problems with the __WinBool type

RobertvanderHulst added a commit to X-Sharp/XSharpDev that referenced this issue Oct 7, 2021

[Tests] Marked C804 as fixed. Fixes #X-Sharp/XSharpPublic/issues/773

fad913e

cpyrgas pushed a commit to X-Sharp/XSharpDev that referenced this issue Oct 21, 2021

[Compiler tests] Adjusted C804 for X-Sharp/XSharpPublic#773

2aaa949

cpyrgas pushed a commit to X-Sharp/XSharpDev that referenced this issue Oct 25, 2021

[Compiler tests] Added one more case to C804 (X-Sharp/XSharpPublic#773)

fe9bde1

RobertvanderHulst added a commit that referenced this issue Oct 25, 2021

[Runtime] Added __WinDate operators needed by #773. These are all for…

e01497c

…warded to the __Date type. Also fixed a problem in __Date:Subtract(USUAL)

RobertvanderHulst added a commit to X-Sharp/XSharpDev that referenced this issue Oct 25, 2021

[Compiler] Fixed assignment from USUAL to __WinDate. Fixes #X-Sharp/X…

025542e

…SharpPublic/issues/773

cpyrgas closed this as completed Oct 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create _WinDate structure that stored Date values in a VO struct just like VO does. #773

Create _WinDate structure that stored Date values in a VO struct just like VO does. #773

RobertvanderHulst commented Sep 6, 2021

leon-ts commented Sep 6, 2021

cpyrgas commented Oct 7, 2021

RobertvanderHulst commented Oct 7, 2021

RobertvanderHulst commented Oct 7, 2021

leon-ts commented Oct 7, 2021

leon-ts commented Oct 8, 2021 •

edited

Loading

RobertvanderHulst commented Oct 11, 2021

cpyrgas commented Oct 11, 2021

RobertvanderHulst commented Oct 11, 2021

cpyrgas commented Oct 11, 2021

leon-ts commented Oct 11, 2021

leon-ts commented Oct 19, 2021 •

edited

Loading

RobertvanderHulst commented Oct 19, 2021

RobertvanderHulst commented Oct 21, 2021

cpyrgas commented Oct 21, 2021

cpyrgas commented Oct 21, 2021

leon-ts commented Oct 21, 2021

cpyrgas commented Oct 30, 2021 •

edited

Loading

leon-ts commented Nov 5, 2021

Create _WinDate structure that stored Date values in a VO struct just like VO does. #773

Create _WinDate structure that stored Date values in a VO struct just like VO does. #773

Comments

RobertvanderHulst commented Sep 6, 2021

leon-ts commented Sep 6, 2021

cpyrgas commented Oct 7, 2021

RobertvanderHulst commented Oct 7, 2021

RobertvanderHulst commented Oct 7, 2021

leon-ts commented Oct 7, 2021

leon-ts commented Oct 8, 2021 • edited Loading

RobertvanderHulst commented Oct 11, 2021

cpyrgas commented Oct 11, 2021

RobertvanderHulst commented Oct 11, 2021

cpyrgas commented Oct 11, 2021

leon-ts commented Oct 11, 2021

leon-ts commented Oct 19, 2021 • edited Loading

RobertvanderHulst commented Oct 19, 2021

RobertvanderHulst commented Oct 21, 2021

cpyrgas commented Oct 21, 2021

cpyrgas commented Oct 21, 2021

leon-ts commented Oct 21, 2021

cpyrgas commented Oct 30, 2021 • edited Loading

leon-ts commented Nov 5, 2021

leon-ts commented Oct 8, 2021 •

edited

Loading

leon-ts commented Oct 19, 2021 •

edited

Loading

cpyrgas commented Oct 30, 2021 •

edited

Loading