Skip to content

Commit

Permalink
adding additions to triage procedure as per comments by centril on di…
Browse files Browse the repository at this point in the history
…scord (rust-lang#250)

* adding additions to triage procedure as per comments by centril on discord

* adding additional info on the RFC form and the last resort nomination process
  • Loading branch information
JohnCSimon authored and Dylan-DPC committed Sep 8, 2019
1 parent 2fe9318 commit 8dfcbd7
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions triage-procedure.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,19 @@ If the PR is blocked on another PR, add a comment clearly identifying the
blocking PR (something like "This PR appears to be blocked on #12345") and
change the state to `S-blocked`.

If the pr is tagged with `final-comment-period` it does not need to be triaged unless the process has stalled for a reasonable period of time. These PRs have a form from RFCbot that looks like:

> Team member **@Donald** has proposed to merge this. The next step is review by the rest of the tagged team members:
> * [ ] @Huey
> * [x] @Dewey
> * [ ] @Louie
At this point, ping the appropriate people to check their boxes to sign off on the PR.

If *this* stalls nominate the PR for prioritizing at the next team triage meeting by marking it with `I-nominated`.

PRs tagged with `finshed-final-comment-period` are eligible for triage.

### [S-waiting-on-team PRs][s-waiting-on-team]

PRs active within the last 4 days or inactive for greater than 2 weeks need to
Expand Down

0 comments on commit 8dfcbd7

Please sign in to comment.