Fix: Use relative path for attachment reference in HTML report #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntduyet
force-pushed
the
duyet/fix-images-url-in-html-report
branch
from
0a8b360
to
043e6e1
Compare
tylervick
approved these changes
Aug 20, 2022
ntduyet
changed the title
|
Hi @tylervick, thanks for review this PR. Would you mind triggering the workflow check again? I've added more tests to cover text attachment as well 🙏 |
|
Apologies for the delay - running this now. Happy to merge when you're ready - I'll also plan to do a patch version bump |
|
I think I'm done with the updates. Please proceed to merge it when you have time. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the broken images issue #274.
Changes
relativeUrlto construct the return value inResultFile.exportPayload(id:, fileName:)