switch relative to absolute url during downsizing #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#275 fixes relative attachment URLs
However, when running the downsizeImages step (with
-zflag), the relative URL is passed to the converter which ultimately fails.To fix this, we'll reconstruct the absolute URL when converting the image. Afterwards, a new relative URL will be returned pointing to the new downsized image.
To test:
Run
xchtmlreport -r path/to/xcresult -zfrom a different working directory, verify heic screenshots are converted to jpeg and properly displayed in the report.