Introduce new variables from corrected LCE map #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce new correction for s1 when using the LCE map calculated after decouling electric field effects. The new variable will be called "cs1", while the previous correction will be changed to "cs1_no_field_corr"
Change made in init: Add the path of the update LCE map for SR1 and the path for the new map of SR0. Waiting to be included in PAX, by PR #661
pdeperio
approved these changes
Jan 5, 2018
|
just as a reminder, Sara's Kr-83m lifetime values dropped when she used the FV I was using as well as s2_bottom by ~10-15 us. Not sure if your lifetime values have been compared with her new ones |
|
Thank you for the info @zachgreene. |
Update with the new LCE maps (with field correction) New corrected S1 with field : cs1_a cs1_b Old Ted's LCE map (no field correction) cs1_a_no_field_corr cs1_b_no_field_corr
|
@MAVJ, @mcfatelin: so according to good agreement in the note here, and comparing the value in first plot above (~455) vs @sdiglio's Kr83m value (452.64), is this OK to merge? |
|
Looks okay to me. Just want to add another reference for Miguel's comparisons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will introduce the new correction for s1 when using the LCE map calculated after decouling electric field effects after taking the average (convergence value) for the electron lifetimes as discussed in #189
Additional information can be found in the Summary Note of this topic.
Changes:
Summary results:
Correction map:
Comparison results:
Correction map:
Comparison results:
If there is something that I missed please just let me know (I'll close #189)
Depends on XENON1T/pax#661