Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path of corrected LCE map in hax.ini #194

Merged

Conversation

MAVJ
Copy link
Contributor

@MAVJ MAVJ commented Jan 5, 2018

Add the path of the update LCE map for SR1 and the path for the new map of SR0. Waiting to be included in PAX, by PR #661

Change made in init:
Add the path of the update LCE map for SR1 and the path for the new map of SR0. Waiting to be included in PAX, by PR #661
@MAVJ MAVJ changed the title Update hax.ini Add path of corrected LCE map in hax.ini Jan 5, 2018
@pdeperio pdeperio self-requested a review January 5, 2018 18:27
Copy link
Contributor

@pdeperio pdeperio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to copy the corrections.py modification from #189 (which wasn't merged) to here.

@MAVJ
Copy link
Contributor Author

MAVJ commented Jan 5, 2018

@pdeperio I included those modifications to corrections.py in this other PR #195. Did you mean those?

@pdeperio
Copy link
Contributor

pdeperio commented Jan 5, 2018

Ah I missed that one. OK I will rebase this one on add_new_corrected_variables_s1 branch and merge into there (they should be in one PR).

@pdeperio pdeperio changed the base branch from master to add_new_corrected_variables_s1 January 5, 2018 18:39
@pdeperio pdeperio merged commit 30f3df9 into add_new_corrected_variables_s1 Jan 5, 2018
@pdeperio pdeperio deleted the add_corrected_lce_map_path branch January 5, 2018 18:40
@MAVJ
Copy link
Contributor Author

MAVJ commented Jan 5, 2018

Thank you Pats, and sorry for the confusion.

feigaodm pushed a commit that referenced this pull request Jan 10, 2018
* Introduce new variables from corrected LCE map

Introduce new correction for s1 when using the LCE map calculated after decouling electric field effects.

The new variable will be called "cs1", while the previous correction will be changed to "cs1_no_field_corr"

* Update hax.ini (#194)

Change made in init:
Add the path of the update LCE map for SR1 and the path for the new map of SR0. Waiting to be included in PAX, by PR #661

* lint fixes

* Remove redundant definition of position variable

* Increment version

* Update CorrectedDoubleS1Scatter.py

Update with the new LCE maps (with field correction)

New corrected S1 with field :
cs1_a
cs1_b 

Old Ted's LCE map (no field correction)
cs1_a_no_field_corr 
cs1_b_no_field_corr

* Increment version

* Update CorrectedDoubleS1Scatter.py

fix lint

* lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants