This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Move all simulation contexts to WFSim #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramirezdiego
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Thanks, @dachengx. Let's wait for the pypi release fixes to merge.
WenzDaniel
approved these changes
Jan 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Together with XENONnT/straxen#1320, to disentangle straxen and wfsim, and make the software environment easier. Because we do not need to maintain compatibility of wfsim inside both wfsim and straxen, e.g. the nestpy(needed by wfsim) currently does not support py3.11(NESTCollaboration/nestpy#104), so we can not update straxen to support py3.11, which is not reasonable.
WFSim needs you:
Pay attention: