Stricter needed parameters check and save meta data to samples #80
Conversation
dachengx
commented
Feb 8, 2023
dachengx
commented
- Drop all unneeded parameters when initializing the context
- Save meta data to MCMC samples(h5 file)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
appletree/context.py
Outdated
| if metadata is None: | ||
| metadata = { | ||
| 'version': '0.0', | ||
| 'date': datetime.now().strftime('%Y%m%d_%H:%M:%S') |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
C812 missing trailing comma
appletree/context.py
Outdated
| return self.par_config | ||
| from_parameters.append(v) | ||
| needed_parameters.add(k) | ||
| for k, v in likelihood['components'].items(): |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
B007 Loop control variable 'v' not used within the loop body. If this is intended, start the name with an underscore.
Pull Request Test Coverage Report for Build 4130527108
💛 - Coveralls |
|
Thanks! Can we also save the instruction of context in meta as well? Then in principle it should be able to recover the whole fitting. |
Good idea. I will add it. |
| from appletree import randgen | ||
| from appletree import Parameter | ||
| from appletree import Likelihood | ||
| from appletree.utils import load_json | ||
| from appletree.share import set_global_config | ||
| from appletree.share import _cached_configs, set_global_config |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
WPS450 Found protected object import: _cached_configs
| if self.backend_h5 is not None: | ||
| name = self.sampler.backend.name | ||
| with h5py.File(self.backend_h5, 'r+') as opt: | ||
| opt[name].attrs['metadata'] = json.dumps(metadata) |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
WPS204 Found overused expression: opt[name]; used 6 > 4
