Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deregister plugins with missing dependencies #85

Closed
wants to merge 1 commit into from

Conversation

dachengx
Copy link
Contributor

After AxFoundation/strax#775, some targets are deregistered when it is provided by a replaced plugin. Like after

for plugin in pmt_and_daq_plugins:
, the raw_records_aqmon will be no longer registered, so that the aqmon_hits and all plugins depend on aqmon_hits can not find there dependencies and an error will raise.

This PR deregisters the plugins without dependencies to fix the error.

But note the configs are still not deleted so you will see something like:

WARNING:strax:Option hit_min_amplitude_nv not taken by any registered plugin

after deregistering those unnecessary plugins.

@dachengx dachengx marked this pull request as ready for review November 29, 2023 20:48
@dachengx
Copy link
Contributor Author

Please let me know if I should submit this to another branch. :)

@HenningSE
Copy link
Collaborator

Thanks @dachengx, I think we wanted to merge all the open PRs in one soon and can then simply include this one.

@ramirezdiego ramirezdiego deleted the branch timing_fix December 22, 2023 12:34
@ramirezdiego
Copy link
Collaborator

ramirezdiego commented Dec 22, 2023

Sorry @dachengx, I deleted the timing_fix branch and this closed the PR (which I thought was built on top of master). We can cherrypick this commit and draft a new PR (or draft it from here: https://github.com/XENONnT/fuse/tree/deregister_plugins_nodeps).

@HenningSE HenningSE deleted the deregister_plugins_nodeps branch January 30, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants