Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deregister plugins with missing dependencies #95

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

dachengx
Copy link
Contributor

@dachengx dachengx commented Jan 9, 2024

replica of #85

After AxFoundation/strax#775, some targets are deregistered when it is provided by a replaced plugin. Like after

for plugin in pmt_and_daq_plugins:
, the raw_records_aqmon will be no longer registered, so that the aqmon_hits and all plugins depend on aqmon_hits can not find there dependencies and an error will raise.

This PR deregisters the plugins without dependencies to fix the error.

But note the configs are still not deleted so you will see something like:

WARNING:strax:Option hit_min_amplitude_nv not taken by any registered plugin

after deregistering those unnecessary plugins.

Copy link
Collaborator

@HenningSE HenningSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for re-opening the PR @dachengx. For me this looks fine!

Copy link
Collaborator

@ramirezdiego ramirezdiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ramirezdiego ramirezdiego merged commit c4a8f72 into main Jan 9, 2024
@ramirezdiego ramirezdiego deleted the deregister_plugins_nodeps_2 branch January 9, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants