Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pulse processing, cleanup #16

Merged
merged 5 commits into from
Jun 17, 2019
Merged

Upgrade pulse processing, cleanup #16

merged 5 commits into from
Jun 17, 2019

Conversation

JelleAalbers
Copy link
Contributor

This adds:

  • Upgraded pulse processing. This requires Multiple outputs and restructured ParallelSourcePlugin AxFoundation/strax#190.
    • The tail veto now also passes large peaks after other large peaks, with a configurable threshold. See software_he_veto for more info.
    • Add veto_regions data type, which lists the regions removed by the software veto.
    • Records for diagnostic PMTs and acquisition monitors are split off to separate data types (diagnostic_records and aqmon_records) for further processing. For the moment I chose the convention that the TPC does not need a prefix (so records is still called records, not tpc_records).
    • Add a pulse_counts data type that counts the number of total and lone PMT pulses (not records) in every chunk (i.e. not per second). "Lone" here means that there is no overlapping pulse in any TPC channel. The count is done before the tail / software veto. This would be a useful data type to show on the online monitor with MongoDB Output AxFoundation/strax#159.
  • Add tests. For the moment, it just downloads a tiny file of test data (same as in the tutorial), processes from raw_records to event_info, and checks there are events with non-zero cS1s. This build will fail until a new strax release with Multiple outputs and restructured ParallelSourcePlugin AxFoundation/strax#190 is made.
  • Add pypi registration for straxen -- why not.
  • Split the plugins over some more files. Change import logic so they are available directly under straxen.xxx rather than straxen.plugins.whatever.xxx.
  • Removes some whitespace from files (pycharm did this automatically)

@JelleAalbers JelleAalbers merged commit 5886178 into master Jun 17, 2019
@JelleAalbers JelleAalbers deleted the new_ll_proc branch June 17, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant