Resurrect fake daq, fix DAQReader time conversion #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to help onsite work. The build failure also affects master and is due to tensorflow/keras changes upstream; will look into this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resurrects the fake_daq script, used to mimic the DAQ on a regular computer. You must point it to a folder with
raw_recordsdata and tell it which run to read; it will then create "live records", if desired at a specific write rate.Perhaps more importantly, this fixes a bug in the DAQReader's absolute time conversion (#17). A bare 1e9 was used, but that gives a float. Our times are 64-bit integers, so doing float math with them leads to inaccuracies. In this case, it led to records with fractional-sample times, which caused strange crashes later in strax.
(I also remove some unused old straxen contexts)