Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete conditional form component #549

Merged
merged 2 commits into from
May 19, 2021

Conversation

endamccormack
Copy link
Contributor

@endamccormack endamccormack commented May 18, 2021

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please also include any acceptance criteria if you have any.

  • Removed redundant ConditionFormComponent file

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce
the testing if necessary.

Before PR's can be merged they will need to be tested by QA and approved where
applicable. To flag the change to QA assign @XGovFormBuilder/qa as one of the reviewers.

  • No testing required as the code was commented out and it will have no affect on functionality

Checklist:

  • My changes do not introduce any new linting errors
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have rebased onto main and there are no code conflicts

@jenbutongit
Copy link
Contributor

ready for review @endamccormack?

@endamccormack endamccormack requested review from a team and jenbutongit May 19, 2021 06:23
@endamccormack endamccormack merged commit 498bea9 into main May 19, 2021
@endamccormack endamccormack deleted the feature/FORMS-566-delete-ConditionFormComponent branch May 19, 2021 10:02
JamesBoadi pushed a commit to JamesBoadi/digital-form-builder-1 that referenced this pull request May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants