Cover update - up/down from bus; stop and movement direction #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change Cover and TravelCalculator to 0% = open 100% = closed
also removed print()s
1 bit telegrams have been inverted if `invert_position` was true. These are specified in knx as 0="up/open" and 1="down/close". I think invert_position shall only be applied to %
as this was only used for unittests
Dpt step corrections
it doesn't matter if 0 or 1 is sent to stop for ABB and MDT actuators. Just fixing the tests here.
|
Up/down from bus seems to have issues with the Workarounds:
Edit: now I know why the telegram boomerangs. See #323 |
javicalle
added a commit
to javicalle/custom_components
that referenced
this pull request
Oct 4, 2020
In v0.12.0 XKNX library have changed the internal OPEN/CLOSED numeric values. From this version 0% is OPEN and 100% is closed. XKNX/xknx#322 `rts_rflink` must adapt the position values sent and received from the library
javicalle
added a commit
to javicalle/custom_components
that referenced
this pull request
Oct 4, 2020
In v0.12.0 XKNX library have changed the internal OPEN/CLOSED numeric values. From this version 0% is OPEN and 100% is closed. XKNX/xknx#322 `rts_rflink` must adapt the position values sent and received from the library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is derived from #259 so
resolves #314
fixes #257 (I hope)
fixes #105 (without implementing the DPT1 state address - just listening for the normal group_address so initial status may be off)
closes #25