-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tunneling: L_Data.con Frames are not awaited properly before sending next L_Data.req #323
Comments
It seems the L_Data.con should be awaited before sending next L_Data.req This would require some redesign of the TelegramQueue and KNXIPInterface classes. As a temporary workaround I suggest to check against the Line 66 in 15134c9
L_Data_CON so the ACK is sent but the callbacks aren't processed again.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please make sure to update to the latest version of xknx (or Home Assistant) and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions. |
I have noticed that, for tunnelling connections, every sent frame is processed twice. Once as OUTGOING and once as INCOMING frame.
When we send a TunnelingRequest the frame is sent as L_Data.req. Transmission shall be confirmed in L_Data.con. We don't handle incoming L_Data.req, L_Data.con and L_Data.ind differently so the confirmation (.con) is treated like an incoming telegram.
I'm not really sure what to do about this. As far as I understand this we should only process (as in fire callbacks) L_Data.ind frames. L_Data.con are just confirmations of our own frames and L_Data.req are only sent by the client (xknx), not by the tunneling server.
Shall we just ignore the L_Data.con frame and hope for the best? Handling this would probably require a second RequestResponse layer for tunneling...
From 3/3/3 Data Link Layer General §2.2:
From 3/6/3 EMI_IMI §4.1.5 Data Link Layer messages
Possibly the underlying issue of home-assistant/core#38130
The text was updated successfully, but these errors were encountered: