Refactor logging in xknx #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-w
force-pushed
the
feature/refactor_logging
branch
from
623a60b
to
127f15c
Compare
This commit aims to remove some of the tight coupling between XKNX and all our subpackages. We now use a dedicated logger for every module. Additionally, when we use `XKNX(log_to_file=True)` we log each and everything to a dedicated file called xknx.log that will be kept for 7 days and will be rotated every night. The default for this is False.
marvin-w
force-pushed
the
feature/refactor_logging
branch
from
127f15c
to
eb406dc
Compare
farmio
reviewed
Sep 25, 2020
marvin-w
force-pushed
the
feature/refactor_logging
branch
from
157db8a
to
10cc8ec
Compare
|
A nice change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to remove some of the tight coupling between XKNX and all our subpackages.
We now use a dedicated logger for every module.
Additionally, when we use
XKNX(log_to_file=True)we log each and everything to a dedicated filecalled xknx.log that will be kept for 7 days and will be rotated every night.
The default for this is False.