Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode payload in HA knx_event #559

Closed
wants to merge 2 commits into from
Closed

Conversation

farmio
Copy link
Member

@farmio farmio commented Jan 11, 2021

Description

decode payload in HA knx_event

TODO:

  • we should add configuration to map group addresses to value_types from yaml too
  • binary is not accepted currently
  • I have not tried DPT3 types yet
  • source the xknx device-tree for group addresses and value_types so already configured gas (eg in sensors) don't have to be configured twice (this could as well be a nice function within xknx)

A configuration key is added to map group addresses to value types (like they are used in sensors).

knx:
  event_filter: ["0/0/*"]
  event_dpt_map:
    "0/0/100": [5, 1]
    "0/0/101": "temperature"
    "0/0/102": 9

#497

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • The documentation has been adjusted accordingly
  • The changes generate no new warnings
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog
  • The Homeassistant plugin has been adjusted in case of new config options

@farmio farmio requested a review from marvin-w January 11, 2021 21:33
@coveralls
Copy link

coveralls commented Jan 11, 2021

Coverage Status

Coverage remained the same at 94.862% when pulling 0df12ee on farmio:dynamic_knx_event into 725e787 on XKNX:master.

@farmio farmio changed the title decode payload in dynamic knx_event decode payload in HA knx_event Jan 12, 2021
Base automatically changed from master to main March 12, 2021 13:07
@marvin-w
Copy link
Member

I like this, looks good for me

@farmio
Copy link
Member Author

farmio commented Oct 13, 2021

see home-assistant/core#57621

@farmio farmio closed this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants