Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance HA knx_event #497

Closed
4 tasks done
farmio opened this issue Nov 17, 2020 · 2 comments · Fixed by #572
Closed
4 tasks done

Enhance HA knx_event #497

farmio opened this issue Nov 17, 2020 · 2 comments · Fixed by #572
Assignees
@marvin-w
Labels
🚀 enhancement enhancements HA-integration

Comments

@farmio
Copy link
Member

farmio commented Nov 17, 2020 •
edited
Loading

There are some requests about updating the HA knx_event.
Eg. home-assistant/core#43256

Currently we just fire the knx_event for incoming telegrams, as stated in the documentation.

We could

  • fire on outgoing telegrams too, not only on incoming
  • add a parameter "direction" for incoming/outgoing
  • add a parameter "source" for IA (eg. to identify which wall switch was used)
  • add a parameter "type" for write or response (maybe also read)

I'm still not very convinced about using the knx_event at all since we can't really decode the payload and dealing with raw payloads should not be a user-facing task in HA (besides maybe for DPT 1/2/3).
@marvin-w marvin-w self-assigned this Nov 17, 2020
@marvin-w marvin-w mentioned this issue Nov 17, 2020
Closed
This was referenced Nov 26, 2020
Merged
Merged
@cassianyoung
Copy link

Hi, did this go into HA 2012.12 ?

@farmio
Copy link
Member Author

farmio commented Dec 15, 2020

No

@farmio farmio mentioned this issue Dec 16, 2020
Merged
10 tasks
@farmio farmio mentioned this issue Jan 11, 2021
Closed
14 tasks
@marvin-w marvin-w mentioned this issue Jan 24, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvin-w marvin-w

Labels
🚀 enhancement enhancements HA-integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Also run callbacks on outgoing telegrams, but filter them out b… marvin-w/xknx
3 participants
@marvin-w @farmio @cassianyoung