Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Also run callbacks on outgoing telegrams, but filter them out b… #572

Merged
merged 4 commits into from Feb 16, 2021

Conversation

marvin-w
Copy link
Member

@marvin-w marvin-w commented Jan 24, 2021

Description

Do trigger telegram callbacks also for outgoing telegrams for HA. For all other callbacks this is disabled by default and has to be explicitly enabled.

Fixes #497

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • The documentation has been adjusted accordingly
  • The changes generate no new warnings
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog
  • The Homeassistant plugin has been adjusted in case of new config options

@coveralls
Copy link

coveralls commented Jan 24, 2021

Coverage Status

Coverage increased (+0.004%) to 94.916% when pulling 2ca47f2 on marvin-w:feature/trigger_knx_event_on_outgoing into afa30c7 on XKNX:master.

@farmio farmio merged commit c9b1c11 into XKNX:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance HA knx_event
3 participants