Run codecov in subshell to prevent blocking build #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codecov's upload to S3 sometimes fails with the following error:
Error: HTTPSConnectionPool(host='codecov.io', port=443): Max retries exceeded with urlI considered using the hacky approach at codecov/codecov-python#158 (comment) but that would have resulted in a pretty messy command for us.
for i in 1 2 3; do /home/circleci/.local/bin/codecov --required -X search gcov pycov -f coverage.xml && break || sleep 30; doneseems like it'd be better, but I guess I don't think we need to hammer codecov's servers. I don't think code coverage reports are that important anyway.Rather than all these retries, I think we should just run it in a subshell. If it works on the run, great. If not, it doesn't block the build. I got the idea from mapbox/mapbox-gl-native#15248.
I don't have a great way to confirm the subshell command works on master, but it's a safe merge.