Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed README -> README.md and amended for markdown support. #97

Merged
merged 1 commit into from
Jun 13, 2020
Merged

Renamed README -> README.md and amended for markdown support. #97

merged 1 commit into from
Jun 13, 2020

Conversation

swmcc
Copy link
Contributor

@swmcc swmcc commented Jun 7, 2020

Thanks for taking the time to open a Pull Request (PR). Please take a moment to review our open/closed PRs above, in case a similar contribution has already been offered.

If you are opening a new Pull Request, please give it a descriptive title and fill out the blanks below, providing as much information as possible.

Pull Requests should be made against our master branch, and rebased if necessary.

What type of Pull Request is this?

  • adds new functionality
  • fixes/improves existing functionality
  • Documentation improvement

Does this PR close any currently open issues?

It does not.

Please explain what this PR does

It brings the README in line with Github Standards and gives a more attractive and intutive document for presentation. If this PR is succesful I can follow it up with other changes to other MARKDOWN files.

Any other information?

I did this change without any consultation.

Where have you tested these changes?

n/a

Copy link
Contributor

@pmhahn pmhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a fast review and only 1 change request.

README.md Outdated Show resolved Hide resolved
@pmhahn pmhahn merged commit f987fc7 into XMLTV:master Jun 13, 2020
@rmeden
Copy link
Contributor

rmeden commented Jun 24, 2020

I received an email that this broke the Makefile.

 Do you want to proceed with this configuration? [yes,no (default=yes)]
 Checking if your kit is complete...
 Warning: the following files are missing in your kit:
 README
 Please inform the author.
 Generating a Unix-style Makefile
 Writing Makefile for XMLTV
 Writing MYMETA.yml and MYMETA.json`

Makefile.PL needs to look for README.MD not README

@garybuhrmaster
Copy link
Contributor

Looks like we (rmeden and I) ran into the same issues at about the same time. Look at issue #102 with proposed patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants