Using gmdate() for displaying timestamps #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance you could update the unit tests to cover this, so we don't break it again in the future? Existing tests for this class are here: The test_formatTimestamp() entry is just marked incomplete. A few simple cases would be better than nothing. And you seem to be very familiar with this method 😀 Thanks for the fix. |
geekwright
added a commit
that referenced
this pull request
Jan 27, 2015
Using gmdate() for displaying timestamps
|
I'll try to get some tests in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since getUserTimestamp() modifies the $time to either the user's 'timezone_offset' or the site's 'Default_TZ' gmdate() should be used so the supplied $usertimestamp won't be affected by the timezone set by the locale.