Updates to installer for xoop_lib location and Doctrine #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Present path definitions early, so we can use code from XOOPS and vendor libraries more freely. Convert all database access to Doctrine or XOOPS system calls. It still defines $xoopsDB for legacy support when core code being called still depends on it. Extended database driver selection to include all platforms Doctrine supports. These will be presented for TESTING and EXPERIMENTAL use only. At present, the PDO MySql driver is the only one offically supported. The list presented is sensitive to what is available and installed in PHP. In addition to MySql, there is support for SqLite, PostGreSql, Sql Server, Oracle and IBM DB2. There are still issues in core when using anything but PDO MySql or MySqli drivers, but progress is being made, and an installer that can generate test cases is an important step. A new format was introduced to pass the varied information required by new drivers from installation to the running system using xoops_data/data/secure.php. XOOPS_DB_PARAMETERS is a serialized array of connection information that can be presented to the connect function. The familiar XOOPS_DB_* defines are still populated, but are not directly used to establish the database connection, unless the XOOPS_DB_PARAMETERS array is not set.
geekwright
added a commit
that referenced
this pull request
Oct 18, 2013
Updates to installer for xoop_lib location and Doctrine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Present path definitions early, so we can use code from XOOPS and vendor libraries more freely.
Convert all database access to Doctrine or XOOPS system calls. It still defines $xoopsDB for legacy support when core code being called still depends on it.
Extended database driver selection to include all platforms Doctrine supports. These will be presented for TESTING and EXPERIMENTAL use only. At present, the PDO MySql driver is the only one offically supported. The list presented is sensitive to what is available and installed in PHP. In addition to MySql, there is support for SqLite, PostGreSql, Sql Server, Oracle and IBM DB2. There are still issues in core when using anything but PDO MySql or MySqli drivers, but progress is being made, and an installer that can generate test cases is an important step.
A new format was introduced to pass the varied information required by new drivers from installation to the running system using xoops_data/data/secure.php. XOOPS_DB_PARAMETERS is a serialized array of connection information that can be presented to the connect function. The familiar XOOPS_DB_* defines are still populated, but are not directly used to establish the database connection, unless the XOOPS_DB_PARAMETERS array is not set.