Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gateway_balances with malformed hotwallet account error response] (Version: [1.11.0-rc2]) #4548

Closed
mounikakun opened this issue May 30, 2023 · 0 comments · Fixed by #4618
Closed

[gateway_balances with malformed hotwallet account error response] (Version: [1.11.0-rc2]) #4548

mounikakun opened this issue May 30, 2023 · 0 comments · Fixed by #4618
Labels
API Change Bug Will Need Documentation

Comments

@mounikakun
Copy link
Collaborator

Issue Description

As per the documentation,
invalidParams - One or more fields are specified incorrectly, or one or more required fields are missing.
invalidHotWallet - One or more of the addresses specified in the hotwallet field is not the Address of an account holding currency issued by the account from the request.

gateway_balances with malformed hotwallet account should return invalidParams instead of invalidHotWallet

Steps to Reproduce

Request:
{ "method": "gateway_balances", "params": [ { "account": "rPMeLRzDEBb2S8kSwynm1if6j6N58xQtv7", "hotwallet": [ "rhKKk5KB8LuxmjvTSA7r3iYmJXGqnno7M" ], "ledger_index": "validated", "strict": true } ] }

Expected Result

invalidParams

Actual Result

invalidHotWallet

Environment

Supporting Files
@mounikakun mounikakun changed the title [gateway_balances with malformed hotwallet account error response] (Version: [rippled version]) [gateway_balances with malformed hotwallet account error response] (Version: [1.11.0-rc2]) May 30, 2023
@PeterChen13579 PeterChen13579 mentioned this issue Jun 30, 2023
Closed
1 task
@PeterChen13579 PeterChen13579 mentioned this issue Jul 12, 2023
Merged
@intelliot intelliot linked a pull request Sep 7, 2023 that will close this issue
APIv2(gateway_balances, channel_authorize): update errors #4618
Merged
intelliot pushed a commit that referenced this issue Sep 21, 2023
@PeterChen13579
APIv2(gateway_balances, channel_authorize): update errors (#4618)
2487dab 
gateway_balances
* When `account` does not exist in the ledger, return `actNotFound`
  * (Previously, a normal response was returned)
  * Fix #4290
* When required field(s) are missing, return `invalidParams`
  * (Previously, `invalidHotWallet` was incorrectly returned)
  * Fix #4548

channel_authorize
* When the specified `key_type` is invalid, return `badKeyType`
  * (Previously, `invalidParams` was returned)
  * Fix #4289

Since these are breaking changes, they apply only to API version 2.

Supersedes #4577
ckeshava pushed a commit to ckeshava/rippled that referenced this issue Sep 22, 2023
@PeterChen13579 @ckeshava
APIv2(gateway_balances, channel_authorize): update errors (XRPLF#4618)
05ac9c9 
gateway_balances
* When `account` does not exist in the ledger, return `actNotFound`
  * (Previously, a normal response was returned)
  * Fix XRPLF#4290
* When required field(s) are missing, return `invalidParams`
  * (Previously, `invalidHotWallet` was incorrectly returned)
  * Fix XRPLF#4548

channel_authorize
* When the specified `key_type` is invalid, return `badKeyType`
  * (Previously, `invalidParams` was returned)
  * Fix XRPLF#4289

Since these are breaking changes, they apply only to API version 2.

Supersedes XRPLF#4577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Change Bug Will Need Documentation
Projects
Core Ledger
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

APIv2(gateway_balances, channel_authorize): update errors PeterChen13579/rippled
2 participants
@intelliot @mounikakun