APIv2(gateway_balances, channel_authorize): update errors #4618
Conversation
This reverts commit 690ce23.
Co-authored-by: Arihant Kothari <40741486+arihantkothari@users.noreply.github.com>
|
@gregtatcam @shawnxie999 Hi guys, I accidentally messed up my git, so I had to create a new PR. This one is exactly the same changes as my old one(#4577); please approve this PR if everything looks good. Thank you |
|
@PeterChen13579 this PR currently has merge conflicts which you'll need to resolve (preferably with a merge commit). @gregtatcam do you have an opinion on whether it's OK for this PR to be merged before #4626? (I have no preference) |
I have no preference either. |
|
@PeterChen13579 - please resolve conflicts - preferably by pushing a merge commit (do not force-push). |
|
Suggested commit message: |
|
LGTM |
intelliot
changed the title
|
note: conflict is expected to go away once #4504 is merged |
|
gateway_balances * When `account` does not exist in the ledger, return `actNotFound` * (Previously, a normal response was returned) * Fix XRPLF#4290 * When required field(s) are missing, return `invalidParams` * (Previously, `invalidHotWallet` was incorrectly returned) * Fix XRPLF#4548 channel_authorize * When the specified `key_type` is invalid, return `badKeyType` * (Previously, `invalidParams` was returned) * Fix XRPLF#4289 Since these are breaking changes, they apply only to API version 2. Supersedes XRPLF#4577
Fix the Windows build by using `unsigned int` (instead of `uint`). The error, introduced by #4618, looks something like: rpc\impl\RPCHelpers.h(299,5): error C2061: syntax error: identifier 'uint' (compiling source file app\ledger\Ledger.cpp)
High Level Overview of Change
Fixed/added error messages for Gateway_balance(issue #4290 | #4548 ) and channel_authorize(#4289 )
Context of Change
Added error messages when user sends an incorrect request. (Check the above Github issue link for more info.) Everything is under API Version 2 as it is a breaking change.
Type of Change
Added own unit test for API Version 2;