Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker.md #4432

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Update Docker.md #4432

merged 2 commits into from
Mar 2, 2023

Conversation

intelliot
Copy link
Collaborator

High Level Overview of Change

Add links to some related resources that may be helpful.

Docker images can make testing amendments (and other functionality) easier to do.

Context of Change

The current Docker.md file is obsolete. This PR is only a stopgap until:

  • thejohnfreeman's images are available in a repo under the XRPLF or Ripple GitHub org
  • The project maintainers start producing images that are ready to use

Type of Change

  • Documentation Updates

@intelliot
Copy link
Collaborator Author

This PR only modifies a markdown file, so I think the unit test failure is due to flakiness

1> ripple.tx.NFToken Payments with IOU transfer fees
2> #132 failed: Subscribe_test.cpp(1132)
2> ripple.basics.contract

@intelliot intelliot merged commit c77a8d5 into develop Mar 2, 2023
@intelliot intelliot deleted the docker-docs branch March 2, 2023 18:07
ximinez added a commit to ximinez/rippled that referenced this pull request Mar 3, 2023
* upstream/develop:
  Set version to 1.10.0-rc4
  Rename 'NFT' to 'NFToken' in DisallowIncoming flags (XRPLF#4442)
  Update Docker.md (XRPLF#4432)
  Update package building scripts and images to use Conan (XRPLF#4435)
  Disable duplicate detector: (XRPLF#4438)
ximinez added a commit to ximinez/rippled that referenced this pull request Mar 3, 2023
* upstream/develop:
  Set version to 1.10.0-rc4
  Rename 'NFT' to 'NFToken' in DisallowIncoming flags (XRPLF#4442)
  Update Docker.md (XRPLF#4432)
  Update package building scripts and images to use Conan (XRPLF#4435)
  Disable duplicate detector: (XRPLF#4438)
ximinez added a commit to ximinez/rippled that referenced this pull request Mar 3, 2023
* upstream/develop:
  Set version to 1.10.0-rc4
  Rename 'NFT' to 'NFToken' in DisallowIncoming flags (XRPLF#4442)
  Update Docker.md (XRPLF#4432)
  Update package building scripts and images to use Conan (XRPLF#4435)
  Disable duplicate detector: (XRPLF#4438)
ximinez added a commit to ximinez/rippled that referenced this pull request Mar 3, 2023
* upstream/develop:
  Set version to 1.10.0-rc4
  Rename 'NFT' to 'NFToken' in DisallowIncoming flags (XRPLF#4442)
  Update Docker.md (XRPLF#4432)
  Update package building scripts and images to use Conan (XRPLF#4435)
  Disable duplicate detector: (XRPLF#4438)
ximinez added a commit to ximinez/rippled that referenced this pull request Mar 3, 2023
* upstream/develop:
  Set version to 1.10.0-rc4
  Rename 'NFT' to 'NFToken' in DisallowIncoming flags (XRPLF#4442)
  Update Docker.md (XRPLF#4432)
ximinez added a commit to ximinez/rippled that referenced this pull request Mar 3, 2023
…ctionality

* upstream/develop:
  Set version to 1.10.0-rc4
  Rename 'NFT' to 'NFToken' in DisallowIncoming flags (XRPLF#4442)
  Update Docker.md (XRPLF#4432)
  Update package building scripts and images to use Conan (XRPLF#4435)
  Disable duplicate detector: (XRPLF#4438)
ximinez added a commit to ximinez/rippled that referenced this pull request Mar 3, 2023
…tpage

* upstream/develop:
  Set version to 1.10.0-rc4
  Rename 'NFT' to 'NFToken' in DisallowIncoming flags (XRPLF#4442)
  Update Docker.md (XRPLF#4432)
  Update package building scripts and images to use Conan (XRPLF#4435)
  Disable duplicate detector: (XRPLF#4438)
dangell7 pushed a commit to Transia-RnD/rippled that referenced this pull request Mar 5, 2023
* Add links to some related resources that may be helpful.
* Docker images can make testing easier to do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants