-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Price Oracles support #2688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the complexity of creating a price data object (with AssetPrice/Scale used to avoid floats), do you think it'd be useful to have a helper function to convert a float to AssetPrice/Scale (and vice versa)?
packages/xrpl/test/integration/transactions/oracleDelete.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the ledger_entry
filter isn't updated for oracle
here.
But I included |
I don't think it's necessary given the docs will explain this. |
@mvadari I'm blocked on figuring out why the browser test fails. Any ideas? |
Missed that, sorry. |
I agree that the docs will explain this, but could be nice to have a helper function do the math for you. Not super important though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
High Level Overview of Change
Add Price Oracles support - XRPLF/XRPL-Standards#129
Context of Change
Adds transactions:
OracleSet
,OracleDelete
Adds request:
get_aggregate_price
Adds ledger entry:
Oracle
Type of Change
Did you update HISTORY.md?
Test Plan
Adds unit/integration tests for Price Oracle transactions and request.