Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getOrderbook #970

Merged
merged 4 commits into from Nov 26, 2018
Merged

Fix getOrderbook #970

merged 4 commits into from Nov 26, 2018

Conversation

intelliot
Copy link
Collaborator

  • Modifies getOrderbook so that orders are sorted correctly

- Use formatBidsAndAsks with request instead of getOrderbook
- Deprecate getOrderbook, which does not sort orders correctly
- Resolve #766
@intelliot intelliot merged commit 0f50562 into develop Nov 26, 2018
@intelliot intelliot deleted the fix-getOrderbook branch November 26, 2018 23:25
@FredKSchott
Copy link
Contributor

Sorry I'm late to seeing this, but belated 👍

Really excited to see this actually, the api.request() method gets to stay flexible & true to the real API interface, but helper methods can still be used to format and/or handle the request/response where user-friendliness is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants