Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Spatial Awareness System #694

Merged
merged 16 commits into from
Dec 20, 2020
Merged

Updated Spatial Awareness System #694

merged 16 commits into from
Dec 20, 2020

Conversation

StephenHodgson
Copy link
Member

@StephenHodgson StephenHodgson commented Nov 24, 2020

XRTK - Mixed Reality Toolkit Pull Request

Overview

  • Updated lumin submodule with latest changes and fixes.
  • Updated LuminBuildTools to check if devices are available before trying to install.

Breaking Changes

  • Removed MeshTrianglesPerCubicMeter from Spatial Mesh Observer Profile
  • Updated SpatialAwarenessMeshLevelOfDetail to be more consistent

Submodule changes

Stephen Hodgson added 2 commits November 24, 2020 01:38
updated lumin submodule checkout
@StephenHodgson StephenHodgson added the In Progress PR currently still being developed label Nov 24, 2020
Stephen Hodgson and others added 4 commits November 24, 2020 23:53
Removed MeshTrianglesPerCubicMeter from Spatial Mesh Observer Profile
Updated SpatialAwarenessMeshLevelOfDetail to be more consistent
@StephenHodgson
Copy link
Member Author

StephenHodgson commented Nov 26, 2020

Blocked, needs 2019.4 LTS

# Conflicts:
#	Submodules/Lumin
updated package info
@StephenHodgson StephenHodgson mentioned this pull request Nov 27, 2020
36 tasks
Stephen Hodgson and others added 6 commits November 27, 2020 16:22
Stephen Hodgson added 2 commits December 20, 2020 14:23
# Conflicts:
#	Submodules/Examples
#	Submodules/SDK
@StephenHodgson StephenHodgson marked this pull request as ready for review December 20, 2020 19:24
@StephenHodgson StephenHodgson removed the In Progress PR currently still being developed label Dec 20, 2020
@StephenHodgson StephenHodgson added the Ready for review PR finished primary development, open for review label Dec 20, 2020
Copy link
Contributor

@FejZa FejZa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd like to see LuminPlayerBuildTools moved to the Lumin module but there is probably a reason for it to be in Core.

@StephenHodgson
Copy link
Member Author

StephenHodgson commented Dec 20, 2020

I'd like to see LuminPlayerBuildTools moved to the Lumin module but there is probably a reason for it to be in Core.

Agreed but that work is slated for 0.3 #596

@StephenHodgson StephenHodgson merged commit 8472dc7 into development Dec 20, 2020
@StephenHodgson StephenHodgson deleted the fix/lumin branch December 20, 2020 19:58
XRTK-Build-Bot pushed a commit that referenced this pull request Dec 25, 2020
* updated lumin build tools

updated lumin submodule checkout

* updated lumin checkout

* updated lumin checkout

* Breaking change

Removed MeshTrianglesPerCubicMeter from Spatial Mesh Observer Profile
Updated SpatialAwarenessMeshLevelOfDetail to be more consistent

* updated submodules

updated package info

* don't iterate over the same gameobjects twice, just clear

* updated submodues

* updated lumin checkout

* updated submodules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Ready for review PR finished primary development, open for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants