Remove AllocsPerRun for non-zero allocation cases

sdk/log/logger_bench_test.go

@@ -8,6 +8,8 @@ import (
 	"testing"
 	"time"
 
+	"github.com/stretchr/testify/assert"
+
 	"go.opentelemetry.io/otel/log"
 	"go.opentelemetry.io/otel/sdk/instrumentation"
 )
@@ -21,19 +23,35 @@ func BenchmarkLoggerNewRecord(b *testing.B) {
 	r.SetBody(log.StringValue("testing body value"))
 	r.SetSeverity(log.SeverityInfo)
 	r.SetSeverityText("testing text")
-	r.AddAttributes(
+
+	attrs5 := []log.KeyValue{
 		log.String("k1", "str"),
 		log.Float64("k2", 1.0),
 		log.Int("k3", 2),
 		log.Bool("k4", true),
 		log.Bytes("k5", []byte{1}),
-	)
-
-	b.ReportAllocs()
-	b.ResetTimer()
-	b.RunParallel(func(pb *testing.PB) {
-		for pb.Next() {
-			logger.newRecord(context.Background(), r)
-		}
+	}
+	r.AddAttributes(attrs5...)
+
+	r10 := r
+	r10.AddAttributes(attrs5...)
+	assert.Equal(b, 10, r10.AttributesLen())
+
+	b.Run("5 attributes", func(b *testing.B) {
+		b.ReportAllocs()
+		b.RunParallel(func(pb *testing.PB) {
+			for pb.Next() {
+				logger.newRecord(context.Background(), r)
+			}
+		})
+	})
+
+	b.Run("10 attributes", func(b *testing.B) {
+		b.ReportAllocs()
+		b.RunParallel(func(pb *testing.PB) {
+			for pb.Next() {
+				logger.newRecord(context.Background(), r10)
+			}
+		})
 	})
 }

sdk/log/logger_test.go

@@ -286,25 +286,14 @@ func TestAllocationLimits(t *testing.T) {
 	r.SetSeverity(log.SeverityInfo)
 	r.SetSeverityText("testing text")
 
-	attrs5 := []log.KeyValue{
-		log.String("k1", "str"),
+	r.AddAttributes(log.String("k1", "str"),
 		log.Float64("k2", 1.0),
 		log.Int("k3", 2),
 		log.Bool("k4", true),
 		log.Bytes("k5", []byte{1}),
-	}
-	r.AddAttributes(attrs5...)
-
-	r10 := r
-	r10.AddAttributes(attrs5...)
-	assert.Equal(t, 10, r10.AttributesLen())
+	)
 
 	assert.Equal(t, 0.0, testing.AllocsPerRun(runs, func() {
 		logger.newRecord(context.Background(), r)
 	}), "newRecord")
-
-	// TODO: Optimize this allocation count to 1.
-	assert.Equal(t, 8.0, testing.AllocsPerRun(runs, func() {
-		logger.newRecord(context.Background(), r10)
-	}), "newRecord with 10 attributes")
 }