fix: implement Close of pipe.Reader #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
可以确定 Mux 的问题与此相关，不过目前直接加上 Close 方法可能会导致未知的调用，所以需要更多测试 |
ghost
感谢群admin 解决了我的使用场景里mux会多跑流量的BUG，场景有限不敢确定，但没实现肯定是个BUG。 可能相关 XTLS#232
|
实现之后出现了新的问题，极大的增加了请求数量（红色区域），导致服务被暂停（黄色区域），换回老版本后正常（绿色区域），很抱歉日志因为服务被关丢失了
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
感谢群admin
解决了我的使用场景里mux会多跑流量的BUG，场景有限不敢确定彻底解决，但没实现肯定是个BUG。
可能相关 #232