Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow whitespace characters to work with replace mode #770

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

J-Fields
Copy link
Contributor

@J-Fields J-Fields commented Jun 6, 2015

Fixes #767

@JugglerShu
Copy link
Contributor

Can you add test cases to the PR?

@structAnkit
Copy link

This works except for three things:

  1. It doesn't replace the last character on a line with an endline; it only deletes that character.
  2. When "replacing" the last character on a line with an endline, XVim breaks and j will not go to lines below the line whose last character you attempted to replace.
  3. When replacing any character but the last one on a line, an endline does replace the character, but it doesn't auto-indent the way you'd expect as you would if you instead do something like x i <Enter>.

I'm not positive how to resolve the issues but would love to see them addressed and implemented! This has been a major pain point of XVim for me.

@elzup
Copy link

elzup commented Apr 19, 2016

A problem occur after this action(r[Enter]).
Undo command not working.

@jasonmay
Copy link

jasonmay commented May 13, 2016

for r<cr> #951 should hopefully handle that

EDIT: looks like these are trying to accomplish the same things. maybe they should be combined if isWhitespace includes \r? I'm not at an environment to check at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants