Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XVimProject/XVim#839 Support block cursor in insert mode #857

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

XVimProject/XVim#839 Support block cursor in insert mode #857

wants to merge 1 commit into from

Conversation

bbudzon
Copy link
Contributor

@bbudzon bbudzon commented Oct 22, 2015

While we can't support everything vim can for guicursor, we can create our own proprietary option (similar to blinkcursor).
I decided to call this new option, blockcursor. It only controls the cursor in insert mode. I couldn't come up with a clever and concise option name that was more indicative of this.

@bbudzon
Copy link
Contributor Author

bbudzon commented Oct 22, 2015

Couldn't think of a good way to unit test this, btw. Open to suggestions.

@carrigmore
Copy link

that is great. How I can use this updated version. Thanks

@bbudzon
Copy link
Contributor Author

bbudzon commented Oct 22, 2015

Unfortunately, it won't be updated until the pull request is accepted. Even then, it will only be in the develop branch and not merged into master.

Once it's merged into master, you should use that.
Once the pull request is accepted, you can use the develop branch.
Until then (and this is not recommended), you can use my https://github.com/neybis/XVim/tree/develop_issue839-block_cursor branch.

@JugglerShu
Copy link
Contributor

I will not merge this soon because we still have problems in cursor in #622.
So if you want use this, pull it from @Neybis repository. Thank you.

@carrigmore
Copy link

hi @JugglerShu, will I get some notification once this is merged? thanks a lot

@bbudzon
Copy link
Contributor Author

bbudzon commented Nov 2, 2015

@carrigmore There is a "subscribe for notifications" button for this pull request. There is also one for the issue #839 and the blocking issue #622. If you subscribe to these, I believe you will receive emails (may be subject to profile settings) if anything changes.

While we can't support everything vim can for guicursor, we can create our own proprietary option (similar to blinkcursor).
I decided to call this new option, blockcursor. It only controls the cursor in insert mode. I couldn't come up with a clever and concise option name that was more indicative of this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants