This repository has been archived by the owner on Feb 6, 2019. It is now read-only.
Fix to add/remove values also from response #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to take a look into as I've lost the context here and I need to check if the use case is legit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the issue #1
Probably closes #1
With @kevinswiber and @XVincentX emerged this situation and we tought that’s a worthwhile change to the plugin.
Use case:
We finished working on v2 api service.
While working on v2 clients or for not updated clients we need the response payload structure to stay the same.
So i take new keys from response v2 and map to "old" v1 keys, but of course with new values.