This repository has been archived by the owner on Jan 26, 2019. It is now read-only.
Refactor of Quoted Literal String Handling and More tests #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the internal representation of a Quoted String Literal from a strangely quoted string to an instance of
\Handlebars\String
.This should move the some of the complexity I previously added to the
\Handlbars\Context::get
method into\Handlebars\Template::parseArguments
Template::parseAruments
onPreviously would have resulted in
And
Context::get
treated it as a string literal based on the string staring and ending with a quote.Now parseArguments results in
and Context::get treats instances of Handlebars\String as string literals.
Also added a couple of new test cases to test the previously uncovered
Template::parseArguments
and added to existing test cases.