Real interferometer #132
Merged
Real interferometer #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 68.70% 70.41% +1.70%
==========================================
Files 26 26
Lines 2732 2687 -45
==========================================
+ Hits 1877 1892 +15
+ Misses 855 795 -60
Continue to review full report at Codecov.
|
sduquemesa
reviewed
May 16, 2022
There was a problem hiding this comment.
Hi @ziofil, this is looking good from my side! ✨ I left some small suggestions and questions on the implementation.
On the testing side, I found a pattern related to making tests deterministic that was common in SF and perhaps we could try to avoid bringing into Mr Mustard. 🔍
Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com>
Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com>
Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com>
Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com>
Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com>
Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com>
sduquemesa
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
It would be nice to have a trainable real interferometer (i.e. one that doesn't mix q and p)
Description of the Change:
I added a new gate:
RealInterferometerBenefits:
We have it now :)
Possible Drawbacks:
None
Related GitHub Issues:
None