Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation of np.str and np.bool #43

Merged
merged 2 commits into from May 25, 2021
Merged

Conversation

thisac
Copy link
Contributor

@thisac thisac commented May 25, 2021

Updates np.str and np.bool to np.str_ and np.bool_ in Blackbird listener.

@thisac thisac requested review from Mandrenkov and josh146 May 25, 2021 17:25
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #43 (5a86771) into master (34f7c6f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          12       12           
  Lines        1914     1914           
=======================================
  Hits         1860     1860           
  Misses         54       54           
Impacted Files Coverage Δ
blackbird_python/blackbird/listener.py 99.59% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34f7c6f...5a86771. Read the comment docs.

@thisac thisac self-assigned this May 25, 2021
Mandrenkov
Mandrenkov previously approved these changes May 25, 2021
Copy link

@Mandrenkov Mandrenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

To be clear, this PR fixes a depreciation warning introduced in NumPy 1.20.

josh146
josh146 previously approved these changes May 25, 2021
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approxing by proxy for @Mandrenkov 🙂

I can't remember, but is there a changelog in this repo?

@thisac thisac dismissed stale reviews from josh146 and Mandrenkov via 5a86771 May 25, 2021 17:38
@thisac thisac requested a review from josh146 May 25, 2021 17:39
@thisac thisac merged commit 0d9c3b2 into master May 25, 2021
@thisac thisac deleted the fix-numpy-str-bool-deprecation branch May 25, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants