Access p-type variables #47
Conversation
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 97.18% 97.30% +0.12%
==========================================
Files 12 12
Lines 1915 1929 +14
==========================================
+ Hits 1861 1877 +16
+ Misses 54 52 -2
Continue to review full report at Codecov.
|
| are otherwise stored in `prog.variables`. This also changes TDM programs to not be templates | ||
| (`prog.is_template` now returns `False`). |
There was a problem hiding this comment.
Just out of curiosity - is there a consequence of TDM programs not being templates any more?
There was a problem hiding this comment.
I don't think so, no. As far as I know this is just a consequence of how we decided to implement these p-type parameters internally. It only blocks the use of the match_template function for all TDM programs (this fixes that).
| @@ -561,7 +561,8 @@ def exitProgram(self, ctx: blackbirdParser.ProgramContext): | |||
| self._program._var.update(_VAR) | |||
| _VAR.clear() | |||
|
|
|||
| self._program._parameters.extend(_PARAMS) | |||
| is_ptype = lambda p: str(p)[0] == "p" and str(p)[1:].isdigit() | |||
There was a problem hiding this comment.
Very minor suggestion, but you could define this function at the module level, since it doesn't seem to depend on closure :)
| def is_ptype(p): | ||
| """Checks whether a parameter is in the form `p0`, `p1`, etc.""" | ||
| return str(p)[0] == "p" and str(p)[1:].isdigit() |
Co-authored-by: Josh Izaac <josh146@gmail.com>
prog.variablesmatch_templateto automatically return matched parameters with their array values, rather than their array names (p0,p1, etc.)prog.parameterssince they're only needed there internally and are otherwise stored inprog.variables. This also changes TDM programs to not be templates (prog.is_templatenow returnsFalse).